acwater issueshttps://gitlab.awi.de/phytooptics/acwater/-/issues2024-01-04T15:57:02Zhttps://gitlab.awi.de/phytooptics/acwater/-/issues/23SWIR output should be set to 0, not to 1.2024-01-04T15:57:02ZDaniel SchefflerSWIR output should be set to 0, not to 1.Currently, the ACwater SWIR output is set to 1, probably, because EnPT used 0 as no-data value so far. However, this changed in https://git.gfz-potsdam.de/EnMAP/GFZ_Tools_EnMAP_BOX/EnPT/-/merge_requests/98 so that 0 is now a valid pixel ...Currently, the ACwater SWIR output is set to 1, probably, because EnPT used 0 as no-data value so far. However, this changed in https://git.gfz-potsdam.de/EnMAP/GFZ_Tools_EnMAP_BOX/EnPT/-/merge_requests/98 so that 0 is now a valid pixel value, i.e., ACwater should set the SWIR output to 0 ([here](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/acwater/acwater.py?ref_type=heads#L188)).https://gitlab.awi.de/phytooptics/acwater/-/issues/22Setting auto_download_ecmwf to False has no effect.2023-12-21T17:39:49ZDaniel SchefflerSetting auto_download_ecmwf to False has no effect.When calling `acwater.acwater.polymer_ac_enmap` with a config where the `auto_download_ecmwf` attribute is set to False (see [here](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/acwater/acwater.py?ref_type=heads#L64)), the auto...When calling `acwater.acwater.polymer_ac_enmap` with a config where the `auto_download_ecmwf` attribute is set to False (see [here](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/acwater/acwater.py?ref_type=heads#L64)), the automatic download of ECMWF data is NOT turned off, i.e., the parameter has no effect. This is because the parameter is just not handled in the code of ACwater.https://gitlab.awi.de/phytooptics/acwater/-/issues/21Improve log output2023-02-08T17:15:19ZDaniel SchefflerImprove log outputThe log output of ACwater looks like this:
merge
2023/02/08 14:09:25: Running polymer...
Initializing ENMAP product of size (30, 1000)
2023/02/08 14:09:26: Landmask is EnMAP L1B
Starting processing at 2023-02-08 14:09:27.116801
Proc...The log output of ACwater looks like this:
merge
2023/02/08 14:09:25: Running polymer...
Initializing ENMAP product of size (30, 1000)
2023/02/08 14:09:26: Landmask is EnMAP L1B
Starting processing at 2023-02-08 14:09:27.116801
Processing block: size (30, 1000), offset (0, 0)
Done in 0:01:31.133461
For the user, `merge` ([this code line](https://gitlab.awi.de/phytooptics/acwater/-/blob/develop/acwater/acwater.py#L72)) is hardly understandable. Could it be removed.
Also [this](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/acwater/acwater.py#L78) does not make much sense to me - at least the context is missing in the log.https://gitlab.awi.de/phytooptics/acwater/-/issues/20Improve ACwater log messages2022-12-08T17:07:00ZDaniel SchefflerImprove ACwater log messagesCurrently, ACwater/Polymer prints the following log messages:
```python
2022/12/08 17:52:51: Currently only tested with ERA5 data, i.e. set True for "auto_download_ecmwf"
2022/12/08 17:53:12: Landmask is EnMAP L1B
```
I think for t...Currently, ACwater/Polymer prints the following log messages:
```python
2022/12/08 17:52:51: Currently only tested with ERA5 data, i.e. set True for "auto_download_ecmwf"
2022/12/08 17:53:12: Landmask is EnMAP L1B
```
I think for the user, they are not really understandable. What is tested with ERA5? Does it mean that the user set the EnPT parameter "auto_download_ecmwf" to True? I also donĀ“t understand what the second message means.https://gitlab.awi.de/phytooptics/acwater/-/issues/18ValueError: 423.03 is not in list2022-12-07T12:48:37ZDaniel SchefflerValueError: 423.03 is not in listSince 1330aa26f06d5d4821e8c85bbfda39bf80d1faa4, I get a ValueError when running EnPT including ACwater/Polymer:
```python
2022/12/07 11:51:41: SICOR atmospheric correction for EnMAP in combined mode successfully finished!
vnir
2022/12...Since 1330aa26f06d5d4821e8c85bbfda39bf80d1faa4, I get a ValueError when running EnPT including ACwater/Polymer:
```python
2022/12/07 11:51:41: SICOR atmospheric correction for EnMAP in combined mode successfully finished!
vnir
2022/12/07 11:51:41: Running polymer...
FAILED
tests/test_controller.py:79 (Test_EnPT_Controller_DLR_testdata_ACWater.test_run_all_processors)
self = <tests.test_controller.Test_EnPT_Controller_DLR_testdata_ACWater testMethod=test_run_all_processors>
def test_run_all_processors(self):
> self.CTR.run_all_processors()
test_controller.py:81:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../enpt/execution/controller.py:184: in run_all_processors
self.run_atmospheric_correction()
../enpt/execution/controller.py:152: in run_atmospheric_correction
self.L1_obj.run_AC()
../enpt/model/images/images_sensorgeo.py:858: in run_AC
AC.run_ac(self)
../enpt/processors/atmospheric_correction/atmospheric_correction.py:252: in run_ac
self._run_AC__combined_mode(enmap_ImageL1)
../enpt/processors/atmospheric_correction/atmospheric_correction.py:189: in _run_AC__combined_mode
polymer_ac_enmap(enmap_l1b=enmap_ImageL1,
../../../../mambaforge/envs/enpt_full/lib/python3.9/site-packages/acwater/acwater.py:101: in polymer_ac_enmap
ibands_vnir = [bands_wavelength.index(b) for b in enmap_l1b.vnir.detector_meta.wvl_center]
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
.0 = <iterator object at 0x7fa5d2b2aeb0>
> ibands_vnir = [bands_wavelength.index(b) for b in enmap_l1b.vnir.detector_meta.wvl_center]
E ValueError: 423.03 is not in list
../../../../mambaforge/envs/enpt_full/lib/python3.9/site-packages/acwater/acwater.py:101: ValueError
```
Unfortuantely, this commit is already included in the master branch, which in turn also breaks EnPT. To avoid that in future, please do not include any untested commits into the master branch of ACwater. I can only recommend to set up a Continuous Integration system for ACwater which automatically runs a set of tests on your code before merging into the master branch.https://gitlab.awi.de/phytooptics/acwater/-/issues/15untrack smallest lfs file2021-06-08T14:44:36ZBrenner Silvauntrack smallest lfs fileFor running in small storage untrack the smallest file used in config, i.e this [sample file](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/tests/data/ENMAP01-____L1B-DT000400126_20170218T110115Z_002_V000204_20200206T182719Z__r...For running in small storage untrack the smallest file used in config, i.e this [sample file](https://gitlab.awi.de/phytooptics/acwater/-/blob/master/tests/data/ENMAP01-____L1B-DT000400126_20170218T110115Z_002_V000204_20200206T182719Z__rows700-730.zip)
```
git lfs untrack 'tests/data/ENMAP01-____L1B-DT000400126_20170218T110115Z_002_V000204_20200206T182719Z__rows700-730.zip'
git rm --cached 'tests/data/ENMAP01-____L1B-DT000400126_20170218T110115Z_002_V000204_20200206T182719Z__rows700-730.zip'
git add 'tests/data/ENMAP01-____L1B-DT000400126_20170218T110115Z_002_V000204_20200206T182719Z__rows700-730.zip'
git commit -m "restore '..rows700-730.zip' to git from lfs"
```Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/14improve Readme2021-04-30T08:52:48ZBrenner Silvaimprove ReadmeArchitecture dependence during installationArchitecture dependence during installationBrenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/13pkgutil and polymer2021-03-25T10:57:14ZBrenner Silvapkgutil and polymerCurrently, acwater runs with enpt when installed in editable mode (due to a symbolic link to the code location) \
However, if not in editable mode, [pkgutils](https://docs.python.org/3/library/pkgutil.html) fails. \
The required path to ...Currently, acwater runs with enpt when installed in editable mode (due to a symbolic link to the code location) \
However, if not in editable mode, [pkgutils](https://docs.python.org/3/library/pkgutil.html) fails. \
The required path to acwater has to be set manually (via GUI), or a proper search, with link to polymer library, when possible.Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/112D array for geometry2021-03-25T10:56:55ZBrenner Silva2D array for geometryrequires revision if 1d array input is needed for (each detector-cell)\
should use 1d-array? \
- no, keep the current version uses a single value for the platform and fills a 1d array based on block size.
- yes, check other case (ex hico...requires revision if 1d array input is needed for (each detector-cell)\
should use 1d-array? \
- no, keep the current version uses a single value for the platform and fills a 1d array based on block size.
- yes, check other case (ex hico) 1d - values are extracted using eh SY, SX coordinates.Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/10how to handle the third dimension?2021-03-25T10:57:34ZBrenner Silvahow to handle the third dimension?For the level1 class, how to handle the third dimension?\
The current solution assumes perfect bands co-registration (i.e. only first array is required)For the level1 class, how to handle the third dimension?\
The current solution assumes perfect bands co-registration (i.e. only first array is required)Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/5sciatran and polymer2021-03-25T10:59:24ZBrenner Silvasciatran and polymerresults are currently not compatible, why? \
either parameterization or input data \results are currently not compatible, why? \
either parameterization or input data \Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/4interface within the toolbox2020-09-15T13:18:00ZBrenner Silvainterface within the toolboxHow to set the config-files?How to set the config-files?Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/3uncertainty - AC-corrected return from polymer2020-09-15T13:17:17ZBrenner Silvauncertainty - AC-corrected return from polymerinclude uncertainty measure
review what can be used here (atmosphere + water, ..)include uncertainty measure
review what can be used here (atmosphere + water, ..)Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/2scaling - AC-corrected return from polymer2020-10-05T08:57:08ZBrenner Silvascaling - AC-corrected return from polymerreview what polymer returns on AC-corrected Rw values to EnPT
* it looks like a scaling/gain of 0.001 is needed
* spectral values don't change from between samples, why?
review:
* enMAP parameters
* radiance at given EnMAP wavelength...review what polymer returns on AC-corrected Rw values to EnPT
* it looks like a scaling/gain of 0.001 is needed
* spectral values don't change from between samples, why?
review:
* enMAP parameters
* radiance at given EnMAP wavelength for polymer (sensitivity)Brenner SilvaBrenner Silvahttps://gitlab.awi.de/phytooptics/acwater/-/issues/1VNIR only2020-10-02T12:14:06ZBrenner SilvaVNIR onlyIs it possible to execute using SWIR bands?Is it possible to execute using SWIR bands?Brenner SilvaBrenner Silva